Fix a bug in the clone method of the layouts #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 87.51% 87.54% +0.03%
==========================================
Files 130 130
Lines 13759 13783 +24
==========================================
+ Hits 12041 12067 +26
+ Misses 1718 1716 -2
Continue to review full report at Codecov.
|
|
Amazing, I was very confused by what could cause that issue. |
philippjfr
pushed a commit
that referenced
this pull request
May 24, 2020
* Fix clone method of layout * Add tests to clone method of layour
philippjfr
added a commit
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1329
Which was caused by a tiny bug in the
clonemethod.