Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] Various fix #1406

Merged
merged 4 commits into from
Jun 12, 2020
Merged

[VTK] Various fix #1406

merged 4 commits into from
Jun 12, 2020

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Jun 12, 2020

Supersedes: #1402
fix: #1401
fix: #1398

image

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #1406 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.01%     
==========================================
  Files         132      132              
  Lines       14665    14689      +24     
==========================================
+ Hits        12883    12907      +24     
  Misses       1782     1782              
Impacted Files Coverage Δ
panel/pane/vtk/synchronizable_serializer.py 84.46% <ø> (ø)
panel/pane/vtk/vtk.py 94.18% <100.00%> (+0.28%) ⬆️
panel/tests/pane/test_vtk.py 98.16% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4375db...d0214d9. Read the comment docs.

@philippjfr
Copy link
Member

Is this ready? I noticed you were asking some of the VTK folks for some help.

@xavArtley
Copy link
Collaborator Author

yes it's ready I found the solution

@philippjfr
Copy link
Member

Fabulous, you rock!

@philippjfr philippjfr merged commit 123466c into master Jun 12, 2020
@philippjfr philippjfr deleted the xav/vtk_various_fix branch June 12, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants