Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error logging for OAuth handlers #1480

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

philippjfr
Copy link
Member

Some cleanup of the code and error handling for the various OAuth providers.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1480 into master will decrease coverage by 0.03%.
The diff coverage is 10.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1480      +/-   ##
==========================================
- Coverage   86.07%   86.04%   -0.04%     
==========================================
  Files         139      139              
  Lines       15560    15567       +7     
==========================================
+ Hits        13394    13395       +1     
- Misses       2166     2172       +6     
Impacted Files Coverage Δ
panel/auth.py 34.64% <8.33%> (-0.58%) ⬇️
panel/io/resources.py 92.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c9e1b...a66b22e. Read the comment docs.

@philippjfr philippjfr merged commit 1097452 into master Jul 15, 2020
@philippjfr philippjfr deleted the oauth_error_logging branch July 15, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant