Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HoloViews plot ranges are merged correctly #1495

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

philippjfr
Copy link
Member

Previously the ranges were not merged correctly and simply inherited from the first plot.

  • Adds test

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1495 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
+ Coverage   86.07%   86.09%   +0.02%     
==========================================
  Files         141      141              
  Lines       15640    15656      +16     
==========================================
+ Hits        13462    13479      +17     
+ Misses       2178     2177       -1     
Impacted Files Coverage Δ
panel/pane/holoviews.py 85.07% <100.00%> (+0.43%) ⬆️
panel/pane/plot.py 54.59% <100.00%> (+0.26%) ⬆️
panel/tests/pane/test_holoviews.py 99.48% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c028511...036f482. Read the comment docs.

@philippjfr philippjfr merged commit 2042bbb into master Jul 23, 2020
@philippjfr philippjfr deleted the hv_range_merge_bug branch July 23, 2020 19:32
@philippjfr philippjfr added this to the v0.10.0 milestone Jul 26, 2020
philippjfr added a commit that referenced this pull request Sep 17, 2020
* Ensure HoloViews plot ranges are merged correctly

* Add test

* Fixed matplotlib bug

* Fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant