Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure callbacks use pn.state.curdoc #1503

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Ensure callbacks use pn.state.curdoc #1503

merged 1 commit into from
Jul 27, 2020

Conversation

philippjfr
Copy link
Member

Using bokeh's curdoc() function means the periodic callbacks cannot easily be used with pn.serve.

@philippjfr philippjfr added this to the v0.10.0 milestone Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1503 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files         142      142           
  Lines       15772    15772           
=======================================
  Hits        13606    13606           
  Misses       2166     2166           
Impacted Files Coverage Δ
panel/callbacks.py 30.43% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ecead...1d5de24. Read the comment docs.

@philippjfr philippjfr merged commit cf60b75 into master Jul 27, 2020
@philippjfr philippjfr deleted the callback_use_state branch July 27, 2020 19:55
philippjfr added a commit that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant