Support size argument on Select widget #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
the
type: enhancement
philippjfr
force-pushed
the
single_select
branch
from
1a2289d
to
8194aff
Compare
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 85.63% 85.65% +0.02%
==========================================
Files 146 146
Lines 16081 16216 +135
==========================================
+ Hits 13771 13890 +119
- Misses 2310 2326 +16
Continue to review full report at Codecov.
|
philippjfr
added a commit
that referenced
this pull request
Sep 17, 2020
* Support size argument on Select widget * Fixed flake * Hide arrow * Factor out SingleSelectBase * Declare base class as abstract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
sizeargument to theSelectwidget which allows rendering an area like theMultiSelectwidget.Implements #255