Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counting of live sessions in session_info #1634

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

philippjfr
Copy link
Member

If a session was established but never rendered it wouldn't count as live but still subtract from the live count.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1634 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         147      147           
  Lines       16717    16719    +2     
=======================================
+ Hits        14277    14279    +2     
  Misses       2440     2440           
Impacted Files Coverage Δ
panel/viewable.py 73.19% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f5b15...14908cf. Read the comment docs.

@philippjfr philippjfr merged commit 3685eea into master Oct 15, 2020
@philippjfr philippjfr deleted the fix_live_count branch October 15, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant