Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use param serializer for synced URL parameters #1658

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

philippjfr
Copy link
Member

Ensures parameter types other than the real basics can be synced with the Location components query parameters.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1658 into master will increase coverage by 0.15%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   85.10%   85.26%   +0.15%     
==========================================
  Files         148      148              
  Lines       16945    17107     +162     
==========================================
+ Hits        14421    14586     +165     
+ Misses       2524     2521       -3     
Impacted Files Coverage Δ
panel/io/location.py 83.92% <76.47%> (-1.64%) ⬇️
panel/template/base.py 74.72% <0.00%> (-0.36%) ⬇️
panel/tests/test_template.py 98.18% <0.00%> (+0.65%) ⬆️
panel/layout/grid.py 81.45% <0.00%> (+6.45%) ⬆️
panel/depends.py 63.63% <0.00%> (+13.63%) ⬆️
panel/template/react/__init__.py 93.44% <0.00%> (+16.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04e39c...ddf2d90. Read the comment docs.

@philippjfr philippjfr merged commit 86fd8f1 into master Oct 20, 2020
@philippjfr philippjfr deleted the location_sync_serializer branch October 20, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant