Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure grid templates support overriding items #1758

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

philippjfr
Copy link
Member

Fixes #1741

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1758 (39946a1) into master (06530a0) will increase coverage by 0.39%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
+ Coverage   84.93%   85.33%   +0.39%     
==========================================
  Files         151      151              
  Lines       17420    17861     +441     
==========================================
+ Hits        14796    15242     +446     
+ Misses       2624     2619       -5     
Impacted Files Coverage Δ
panel/template/base.py 72.65% <50.00%> (+0.29%) ⬆️
panel/widgets/slider.py 93.95% <81.81%> (+2.25%) ⬆️
panel/layout/card.py 95.74% <100.00%> (ø)
panel/layout/grid.py 76.82% <100.00%> (+0.57%) ⬆️
panel/template/react/__init__.py 100.00% <100.00%> (ø)
panel/tests/test_server.py 100.00% <100.00%> (ø)
panel/tests/test_template.py 79.13% <100.00%> (+2.52%) ⬆️
panel/tests/widgets/test_slider.py 100.00% <100.00%> (ø)
panel/pane/alert.py 100.00% <0.00%> (ø)
panel/tests/test_docs.py 100.00% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556c1f6...39946a1. Read the comment docs.

@philippjfr philippjfr merged commit 06d41a9 into master Nov 10, 2020
@philippjfr philippjfr deleted the override_react_grid branch November 10, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update main when main is GridSpec
1 participant