Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress=True #1778

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Add progress=True #1778

merged 3 commits into from
Nov 13, 2020

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Nov 13, 2020 •
edited
Loading

#1776

import hvplot.xarray
import xarray as xr
import panel as pn
pn.extension()

ds = xr.tutorial.open_dataset('air_temperature')
pane = pn.panel(ds.hvplot('lon', 'lat'))
pane.save('test.html', embed=True, progress=True)

image

philippjfr
philippjfr reviewed Nov 13, 2020
View reviewed changes
panel/viewable.py
"""
return save(self, filename, title, resources, template,
template_variables, embed, max_states, max_opts,
embed_json, json_prefix, save_path, load_path,
embed_states)
progress, embed_states)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was broken before. Really should have used keywords here.

philippjfr
philippjfr reviewed Nov 13, 2020
View reviewed changes
panel/viewable.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Thanks @ahuang11!

@philippjfr philippjfr merged commit 5694697 into holoviz:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahuang11 @philippjfr