Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] Implement Glyph3Dmapper serialization - Round 2 #2003

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

xavArtley
Copy link
Collaborator

fix fix: #2001

image

@xavArtley xavArtley changed the title Xav/vtk glyph3dmapper [VTK] Implement Glyph3Dmapper serialization - Round 2 Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2003 (49b6b74) into master (2b33b05) will increase coverage by 0.22%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   84.58%   84.81%   +0.22%     
==========================================
  Files         164      166       +2     
  Lines       19823    19996     +173     
==========================================
+ Hits        16768    16960     +192     
+ Misses       3055     3036      -19     
Impacted Files Coverage Δ
panel/pane/vtk/vtk.py 96.39% <ø> (-0.03%) ⬇️
panel/pane/vtk/synchronizable_serializer.py 79.93% <70.00%> (-0.91%) ⬇️
panel/pane/vtk/synchronizable_deserializer.py 97.58% <100.00%> (+0.08%) ⬆️
panel/models/__init__.py 100.00% <0.00%> (ø)
panel/widgets/__init__.py 100.00% <0.00%> (ø)
panel/tests/widgets/test_trend_indicator.py 76.92% <0.00%> (ø)
panel/models/trend.py 100.00% <0.00%> (ø)
panel/tests/widgets/test_tables.py 99.23% <0.00%> (+0.06%) ⬆️
panel/widgets/tables.py 83.80% <0.00%> (+0.47%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b33b05...49b6b74. Read the comment docs.

@philippjfr
Copy link
Member

Ready?

@xavArtley
Copy link
Collaborator Author

I hope

@philippjfr philippjfr merged commit 72441fd into master Feb 24, 2021
@philippjfr philippjfr deleted the xav/vtk_glyph3dmapper branch February 24, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtkGlyph3DMapper on Panel + JupyterLab gives javascript error, blank screen
2 participants