Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always wrap Div and widgets in WidgetBox #25

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Conversation

philippjfr
Copy link
Member

Makes the handling of Div and widget bokeh models more consistent by always wrapping them in a widget box, which inherits width/height/sizing_mode from the model.

@codecov-io
Copy link

Codecov Report

Merging #25 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   92.68%   92.71%   +0.02%     
==========================================
  Files          19       19              
  Lines        2242     2236       -6     
==========================================
- Hits         2078     2073       -5     
+ Misses        164      163       -1
Impacted Files Coverage Δ
panel/tests/test_panes.py 97.9% <100%> (-0.07%) ⬇️
panel/util.py 77.88% <100%> (+0.74%) ⬆️
panel/pane.py 82.52% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cea6f2...bd035f8. Read the comment docs.

@philippjfr philippjfr merged commit f685db4 into master Sep 5, 2018
@philippjfr philippjfr deleted the div_widgetbox_fix branch October 17, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants