Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bokeh correctly detects whether HTML/Markdown contains latex #3438

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 21, 2022

Fixes #3429

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #3438 (0e2c05b) into master (325f471) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   82.93%   82.92%   -0.01%     
==========================================
  Files         198      198              
  Lines       27017    27018       +1     
==========================================
- Hits        22407    22406       -1     
- Misses       4610     4612       +2     
Impacted Files Coverage Δ
panel/config.py 58.75% <0.00%> (-0.17%) ⬇️
panel/models/markup.py 100.00% <100.00%> (ø)
panel/io/state.py 69.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325f471...0e2c05b. Read the comment docs.

@philippjfr
Copy link
Member Author

philippjfr commented Apr 21, 2022

@MarcSkovMadsen So the fast templates have this bit of CSS in them:

  :not(:defined) {
    visibility: hidden;
  }

This seems to hide the mjx-container tags that MathJax adds to the page to render the LaTeX output. Do you recall why this rule had to be added?

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Apr 22, 2022

Yes. The fast documentation specifiks they should be added to avoid having the page look weird until web components have been defined and can be rendered correctly.

@philippjfr
Copy link
Member Author

So it should be removed after the page is fully rendered?

@philippjfr
Copy link
Member Author

Will merge and fix the fast template issue separately.

@philippjfr philippjfr merged commit 2ba0b94 into master Apr 22, 2022
@philippjfr philippjfr deleted the math_rendering_fix branch April 22, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown pane does not render latex without adding "mathjax" to pn.extension
2 participants