Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure selection on filtered Tabulator does not raise out-of-bounds error #3462

Merged
merged 1 commit into from Apr 28, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3452

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #3462 (f23bc54) into master (867556b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
- Coverage   83.15%   83.14%   -0.02%     
==========================================
  Files         199      199              
  Lines       27077    27071       -6     
==========================================
- Hits        22516    22508       -8     
- Misses       4561     4563       +2     
Impacted Files Coverage Δ
panel/widgets/tables.py 88.56% <100.00%> (ø)
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/io/server.py 78.04% <0.00%> (-0.22%) ⬇️
panel/io/state.py 70.38% <0.00%> (-0.22%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️
panel/io/callbacks.py 72.99% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867556b...f23bc54. Read the comment docs.

@philippjfr philippjfr merged commit 5901a3b into master Apr 28, 2022
@philippjfr philippjfr deleted the filter_sel_oob branch April 28, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError in Tabulator with add_filter
1 participant