Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabulator events when the original column is not a string #3541

Merged
merged 1 commit into from
May 20, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 20, 2022

This makes use of the _renamed_cols dictionary to retrieve the original column name.

use the original column name instead of the processed one
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #3541 (2c6131b) into master (c2fa59d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3541      +/-   ##
==========================================
- Coverage   82.77%   82.76%   -0.02%     
==========================================
  Files         199      199              
  Lines       27410    27405       -5     
==========================================
- Hits        22689    22682       -7     
- Misses       4721     4723       +2     
Impacted Files Coverage Δ
panel/widgets/tables.py 88.78% <100.00%> (+0.01%) ⬆️
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/io/state.py 67.02% <0.00%> (-0.22%) ⬇️
panel/io/server.py 76.35% <0.00%> (-0.21%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️
panel/io/callbacks.py 75.38% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fa59d...2c6131b. Read the comment docs.

@philippjfr philippjfr merged commit eb158bc into master May 20, 2022
@philippjfr philippjfr deleted the fix_keyerror_edit_intcol branch May 20, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants