Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute method to run callbacks and add support to asynchronous on_edit/on_click tabulator callbacks #3550

Merged
merged 13 commits into from
May 23, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 23, 2022

This is achieved through the addition of the run_callback method on the states that delegates to the callback call to the right context.

Should there me more usage of run_callback throughout the code base? e.g. should theon_click button events make use of it?

panel/io/state.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #3550 (3357f49) into master (0dab3ba) will increase coverage by 0.02%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
+ Coverage   82.76%   82.79%   +0.02%     
==========================================
  Files         199      199              
  Lines       27435    27470      +35     
==========================================
+ Hits        22707    22743      +36     
+ Misses       4728     4727       -1     
Impacted Files Coverage Δ
panel/widgets/tables.py 88.77% <66.66%> (ø)
panel/io/state.py 67.92% <100.00%> (+0.68%) ⬆️
panel/tests/widgets/test_tables.py 99.63% <100.00%> (+0.01%) ⬆️
panel/io/server.py 76.56% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dab3ba...3357f49. Read the comment docs.

panel/io/state.py Outdated Show resolved Hide resolved
@maximlt maximlt changed the title Tabulator: allow on_edit and on_click to execute async callbacks Add execute method to run and add support to asynchronous on_edit/on_click tabulator callbacks May 23, 2022
@maximlt maximlt changed the title Add execute method to run and add support to asynchronous on_edit/on_click tabulator callbacks Add execute method to run callbacks and add support to asynchronous on_edit/on_click tabulator callbacks May 23, 2022
@philippjfr philippjfr merged commit 0161763 into master May 23, 2022
@philippjfr philippjfr deleted the more_async_support branch May 23, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants