Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotation to _rename attribute #3561

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Add type annotation to _rename attribute #3561

merged 9 commits into from
Jun 9, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fixes typing errors when trying to inherit from Panel class with _rename attribute.

image

@MarcSkovMadsen MarcSkovMadsen changed the title Add typing to _rename Add type annotation to _rename May 26, 2022
panel/io/location.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #3561 (32fa747) into master (6752cd5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
+ Coverage   82.71%   82.74%   +0.02%     
==========================================
  Files         202      202              
  Lines       27585    27646      +61     
==========================================
+ Hits        22817    22875      +58     
- Misses       4768     4771       +3     
Impacted Files Coverage Δ
panel/io/location.py 82.97% <100.00%> (ø)
panel/layout/accordion.py 90.00% <100.00%> (+0.20%) ⬆️
panel/layout/base.py 92.21% <100.00%> (ø)
panel/layout/card.py 96.49% <100.00%> (+0.12%) ⬆️
panel/layout/grid.py 75.07% <100.00%> (+0.14%) ⬆️
panel/layout/gridstack.py 54.09% <100.00%> (+1.55%) ⬆️
panel/layout/tabs.py 91.15% <100.00%> (+0.15%) ⬆️
panel/pane/alert.py 100.00% <100.00%> (ø)
panel/pane/deckgl.py 73.75% <100.00%> (+0.37%) ⬆️
panel/pane/echarts.py 78.33% <100.00%> (+0.74%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6752cd5...32fa747. Read the comment docs.

@MarcSkovMadsen MarcSkovMadsen changed the title Add type annotation to _rename Add type annotation to _rename attribute May 26, 2022
@philippjfr philippjfr merged commit 5385430 into master Jun 9, 2022
@philippjfr philippjfr deleted the rename-typing branch June 9, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants