New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BasicTemplate type hints #3562
Conversation
I don't know how you got type hints in using |
Codecov Report
@@ Coverage Diff @@
## master #3562 +/- ##
==========================================
- Coverage 82.82% 82.79% -0.04%
==========================================
Files 199 199
Lines 27518 27471 -47
==========================================
- Hits 22792 22744 -48
- Misses 4726 4727 +1
Continue to review full report at Codecov.
|
The union operator is compatible with |
Thanks. Does it mean I should refactor this one to annotate using |
I can see from #3560 (comment) that it does. I will update. |
Perfect, thanks! |
e448b41
to
47fa352
Compare
Finished typing |
Fixes issues like below