Update expand icon on expanded change #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3703 +/- ##
==========================================
- Coverage 83.76% 83.76% -0.01%
==========================================
Files 210 210
Lines 30202 30223 +21
==========================================
+ Hits 25300 25317 +17
- Misses 4902 4906 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
reviewed
Aug 10, 2022
panel/models/tabulator.ts
Outdated
Comment on lines
261
to
263
| if (row.cells.length > 0) { | ||
| row.cells[0].layoutElement() | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (row.cells.length > 0) { | |
| row.cells[0].layoutElement() | |
| } | |
| if (row.cells.length > 0) | |
| row.cells[0].layoutElement() |
philippjfr
force-pushed
the
update_icon_on_expanded_change
branch
from
aaeb982
to
2b241eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3646
By going through the rows when
expandedis changed and resetting the expand icon for each row.