Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page Parameter when pagination is 'local' #3704

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 20, 2022

Fixes #3647

By setting up the pageLoaded callback that is triggered on page change by Tabulator JS, and within which the page model attribute is set when pagination is 'local'. By the way this check is there to be explicit as I didn't see the callback being triggered when pagination is 'remote'.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #3704 (c1404fe) into master (b827be2) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3704      +/-   ##
==========================================
+ Coverage   83.32%   83.55%   +0.22%     
==========================================
  Files         207      207              
  Lines       29654    29654              
==========================================
+ Hits        24709    24777      +68     
+ Misses       4945     4877      -68     
Flag Coverage Δ
ui-tests 31.90% <100.00%> (-0.01%) ⬇️
unitexamples-tests 78.19% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 98.08% <100.00%> (ø)
panel/tests/util.py 84.37% <0.00%> (-1.05%) ⬇️
panel/util.py 86.36% <0.00%> (-0.38%) ⬇️
panel/io/server.py 76.56% <0.00%> (+0.20%) ⬆️
panel/io/reload.py 71.73% <0.00%> (+2.17%) ⬆️
panel/widgets/terminal.py 70.89% <0.00%> (+20.18%) ⬆️
panel/tests/widgets/test_terminal.py 58.87% <0.00%> (+22.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@philippjfr philippjfr merged commit 70fa6fb into master Aug 23, 2022
@philippjfr philippjfr deleted the update_page_local branch August 23, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: page not updated when pagination is 'local'
2 participants