Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting datetime bounds for DatetimePicker and DatetimeRangePicker #3788

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Supporting datetime bounds for DatetimePicker and DatetimeRangePicker #3788

merged 2 commits into from
Aug 29, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 29, 2022

I noticed the options minDateHasTime and maxDateHasTime

screenrecord-2022-08-29_12.23.48.mp4
import datetime

import panel as pn

datetime_picker = pn.widgets.DatetimePicker(
    name="Datetime Picker",
    value=datetime.datetime(2021, 3, 2, 12, 10),
    end=datetime.datetime(2021, 3, 4, 12, 10),
    start=datetime.datetime(2021, 3, 1, 12, 10),
)

pn.Row(
    datetime_picker,
    f"start: {datetime_picker.start}",
    f"end: {datetime_picker.end}",
).servable()

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3788 (c6e19fc) into master (5cbc4fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3788      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.04%     
==========================================
  Files         220      220              
  Lines       31933    31925       -8     
==========================================
+ Hits        26452    26459       +7     
+ Misses       5481     5466      -15     
Flag Coverage Δ
ui-tests 33.71% <7.69%> (-0.01%) ⬇️
unitexamples-tests 75.84% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_input.py 100.00% <100.00%> (ø)
panel/widgets/input.py 96.17% <100.00%> (+0.11%) ⬆️
panel/reactive.py 78.31% <0.00%> (+0.66%) ⬆️
panel/util.py 87.16% <0.00%> (+0.75%) ⬆️
panel/widgets/debugger.py 92.96% <0.00%> (+4.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 7550f75 into holoviz:master Aug 29, 2022
@philippjfr
Copy link
Member

Thanks @hoxbro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants