Tabulator: ignore case when sorting strings #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3825 +/- ##
==========================================
+ Coverage 83.00% 83.02% +0.01%
==========================================
Files 221 221
Lines 32312 32328 +16
==========================================
+ Hits 26821 26840 +19
+ Misses 5491 5488 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
reviewed
Sep 12, 2022
|
One suggestion about taking fixed length string and unicode columns into account, otherwise this looks good. |
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabulator JS implements its own sorting algorithms which for the string type ignores the case, while
df.sort_valuesdoes and is used internally to mirror what happens on the client side. This PR adds a key function tosort_valuesso that strings are temporally lower-cased to sort them.