Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Django compatibility #3835

Merged
merged 2 commits into from Sep 14, 2022
Merged

Handle Django compatibility #3835

merged 2 commits into from Sep 14, 2022

Conversation

philippjfr
Copy link
Member

Improve dispatching to DjangoConsumer in panel.io.document.unlocked contextmanager and add forward compatibility for bokeh_django.

@sdc50 Please test.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3835 (a0ef99e) into master (3a7a791) will decrease coverage by 0.09%.
The diff coverage is 24.00%.

@@            Coverage Diff             @@
##           master    #3835      +/-   ##
==========================================
- Coverage   82.89%   82.80%   -0.10%     
==========================================
  Files         222      222              
  Lines       32395    32411      +16     
==========================================
- Hits        26853    26837      -16     
- Misses       5542     5574      +32     
Flag Coverage Δ
ui-tests 33.88% <8.00%> (-0.34%) ⬇️
unitexamples-tests 75.24% <24.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/document.py 61.76% <9.52%> (-4.91%) ⬇️
panel/io/django.py 30.76% <100.00%> (+4.23%) ⬆️
panel/tests/ui/io/test_jupyter_server_extension.py 40.74% <0.00%> (-59.26%) ⬇️
panel/tests/conftest.py 86.78% <0.00%> (-1.33%) ⬇️
panel/util.py 86.41% <0.00%> (-0.76%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 0911b29 into master Sep 14, 2022
@philippjfr philippjfr deleted the django_compat branch September 14, 2022 17:50
@sdc50
Copy link
Contributor

sdc50 commented Sep 15, 2022

@philippjfr Sorry I didn't see this yesterday. I just tested and it works great!

I'm still working through what needs to be fixed when setting BOKEH_RESOURCES to server. From what I can tell so far it seems to be a limitation with bokeh.embed.bundle.bundle_for_objs_and_resources not allowing you to specify a root_url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants