Tabulator: simplify event row calculation #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3841 +/- ##
=======================================
Coverage 82.86% 82.87%
=======================================
Files 222 222
Lines 32426 32427 +1
=======================================
+ Hits 26871 26875 +4
+ Misses 5555 5552 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Agree this is significantly cleaner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the actual (i.e. visual) position of the row clicked/edited this PR computes an index mapping - that relies on the existence of the hidden
_indexcolumn used on the front-side for other reasons - and use that index when processing a click/edit event to obtain the actual row iloc in the value DataFrame. This has the effect to not have to rely on sorting data to get the row iloc, which as seen recently caused issue due to divergences between Tabulator JS' sorting algorithms and Pandasdf.sort_values().