Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django_url_configuration #3843

Merged
merged 1 commit into from Sep 15, 2022
Merged

Conversation

sdc50
Copy link
Contributor

@sdc50 sdc50 commented Sep 15, 2022

handle django configuration where domain name is not included in url passed to server document.

Passing in a URL without the domain (i.e.):

script = server_document(request.get_full_path())

instead of:

script = server_document(request.build_absolute_uri())

Is required when serving behind a reverse web proxy that terminates HTTPS requests. Otherwise you will get a Mixed Content type error and autoload.js will not be served.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3843 (5fa742f) into master (77749c2) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
- Coverage   82.86%   82.86%   -0.01%     
==========================================
  Files         222      222              
  Lines       32452    32453       +1     
==========================================
  Hits        26891    26891              
- Misses       5561     5562       +1     
Flag Coverage Δ
ui-tests 34.20% <25.00%> (-0.01%) ⬇️
unitexamples-tests 75.28% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/django.py 30.18% <0.00%> (-0.59%) ⬇️
panel/io/server.py 74.85% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 213bb21 into holoviz:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants