Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues editing a cell when client-side filtering applied #3852

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

philippjfr
Copy link
Member

When editing a cell and the new value is filtered by the currently set client-side filters we need to keep track of the edited rows to ensure they are not filtered out until the filters are updated and the client-side filtering is recomputed.

Fixes #3831

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #3852 (97d6159) into master (213bb21) will increase coverage by 0.13%.
The diff coverage is 90.09%.

@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
+ Coverage   82.86%   82.99%   +0.13%     
==========================================
  Files         222      224       +2     
  Lines       32453    32675     +222     
==========================================
+ Hits        26891    27120     +229     
+ Misses       5562     5555       -7     
Flag Coverage Δ
ui-tests 34.40% <85.14%> (+0.20%) ⬆️
unitexamples-tests 75.22% <10.89%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/pyodide.py 0.00% <0.00%> (ø)
panel/widgets/tables.py 88.06% <52.94%> (-0.49%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 98.93% <100.00%> (+0.05%) ⬆️
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/io/test_mime_render.py 100.00% <0.00%> (ø)
panel/io/mime_render.py 88.77% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b4ab9aa into master Sep 16, 2022
@philippjfr philippjfr deleted the tabulator_header_edit branch September 16, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when editing a cell in a client-side filtered column
2 participants