Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CDN migration #3870

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Finish CDN migration #3870

merged 4 commits into from
Sep 22, 2022

Conversation

philippjfr
Copy link
Member

Use config.npm_cdn for template resources.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #3870 (42f818d) into master (18d2215) will decrease coverage by 40.42%.
The diff coverage is 21.05%.

@@             Coverage Diff             @@
##           master    #3870       +/-   ##
===========================================
- Coverage   75.09%   34.67%   -40.43%     
===========================================
  Files         224      224               
  Lines       32816    32812        -4     
===========================================
- Hits        24642    11376    -13266     
- Misses       8174    21436    +13262     
Flag Coverage Δ
ui-tests 34.67% <21.05%> (?)
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/auth.py 39.20% <ø> (ø)
panel/io/convert.py 30.43% <ø> (ø)
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/io/server.py 23.00% <ø> (-51.66%) ⬇️
panel/models/ace.py 0.00% <ø> (-91.67%) ⬇️
panel/template/base.py 35.43% <0.00%> (-40.73%) ⬇️
panel/compiler.py 6.49% <16.66%> (+0.35%) ⬆️
panel/template/fast/base.py 69.56% <100.00%> (-27.14%) ⬇️
panel/template/material/__init__.py 100.00% <100.00%> (ø)
panel/template/react/__init__.py 57.14% <100.00%> (-42.86%) ⬇️
... and 174 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 845f4cc into master Sep 22, 2022
@philippjfr philippjfr deleted the cdn_migration branch September 22, 2022 11:49
@hoxbro
Copy link
Member

hoxbro commented Sep 26, 2022

After this PR Lumen Builder looks like this:

image

2022-09-26 11:24:40,970 Starting Bokeh server version 2.4.3 (running on Tornado 6.2)
2022-09-26 11:24:40,970 User authentication hooks NOT provided (default user enabled)
2022-09-26 11:24:40,972 Bokeh app running at: http://localhost:5006/ui
2022-09-26 11:24:40,972 Starting Bokeh server with process id: 69777
2022-09-26 11:24:42,993 W-1002 (EMPTY_LAYOUT): Layout has no children: Column(id='1015', ...)
2022-09-26 11:24:43,101 404 GET /static/extensions/panel/bundled/js/@microsoft/fast-colors@5.3.1/dist/index.js (127.0.0.1) 0.61ms
2022-09-26 11:24:43,102 404 GET /static/extensions/panel/bundled/js/@microsoft/fast-components@1.21.8/dist/fast-components.js (127.0.0.1) 0.66ms
2022-09-26 11:24:43,330 WebSocket connection opened
2022-09-26 11:24:43,331 ServerConnection created

@philippjfr
Copy link
Member Author

Are you on Panel master? I cannot reproduce.

@hoxbro
Copy link
Member

hoxbro commented Sep 26, 2022

Yes. Both on panel and lumen.

@philippjfr
Copy link
Member Author

You'll have to fetch the latest resources by rerunning an editable install on Panel.

@philippjfr
Copy link
Member Author

Alternatively you can also just run panel.compiler.bundle_resources()

@hoxbro
Copy link
Member

hoxbro commented Sep 26, 2022

It works now.

I needed to run python setup.py develop. python -m pip install --no-build-isolation --no-deps -e . was not enough.

@philippjfr
Copy link
Member Author

python -m pip install --no-build-isolation --no-deps -e . was not enough.

Probably due to latest pip nonsense. Setting this probably would have done it:

SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"

@philippjfr
Copy link
Member Author

cdn.holoviz.org is what it should be using.

@philippjfr
Copy link
Member Author

Neither unpkg nor jsdelivr are recommended for production usage so we decided to maintain our own CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants