Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyodide conversion in subprocess #3878

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Run pyodide conversion in subprocess #3878

merged 1 commit into from
Sep 23, 2022

Conversation

philippjfr
Copy link
Member

Allows for parallel conversion and isolates the environment the conversion happens in.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #3878 (48c4cfb) into master (c8ae3d9) will decrease coverage by 0.00%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master    #3878      +/-   ##
==========================================
- Coverage   82.85%   82.84%   -0.01%     
==========================================
  Files         215      215              
  Lines       32381    32372       -9     
==========================================
- Hits        26829    26820       -9     
  Misses       5552     5552              
Flag Coverage Δ
ui-tests 34.38% <9.09%> (-0.01%) ⬇️
unitexamples-tests 74.92% <9.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/command/convert.py 64.28% <ø> (ø)
panel/io/convert.py 29.57% <9.09%> (-0.87%) ⬇️
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/io/state.py 69.16% <0.00%> (-0.19%) ⬇️
panel/tests/util.py 89.21% <0.00%> (-0.11%) ⬇️
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/tests/ui/widgets/test_tabulator.py 99.06% <0.00%> (+0.10%) ⬆️
panel/pane/idom.py 28.36% <0.00%> (+0.19%) ⬆️
panel/tests/conftest.py 88.59% <0.00%> (+0.38%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit ef6ed43 into master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant