Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load notyf resources unless notifications are enabled #3958

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

philippjfr
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #3958 (d242f16) into master (a5bd963) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3958   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files         223      223           
  Lines       32971    32975    +4     
=======================================
+ Hits        27611    27616    +5     
+ Misses       5360     5359    -1     
Flag Coverage Δ
ui-tests 36.95% <75.00%> (-0.01%) ⬇️
unitexamples-tests 74.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/config.py 76.26% <100.00%> (+0.19%) ⬆️
panel/io/notifications.py 64.44% <100.00%> (+0.39%) ⬆️
panel/reactive.py 78.09% <0.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 52ca16a into master Oct 5, 2022
@philippjfr philippjfr deleted the notifications_load branch October 5, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: offline bokeh plot support broken
1 participant