Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle resource mode in conversion #3967

Merged
merged 7 commits into from
Oct 8, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 6, 2022

Fixes issues with resolving Tabulator theme resources correctly in converted Panel application.

Also ensures that panel convert tests are run against a locally built wheel.

@philippjfr philippjfr added this to the Version 0.14.1 milestone Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #3967 (063008d) into master (86cb7ea) will decrease coverage by 0.01%.
The diff coverage is 91.93%.

@@            Coverage Diff             @@
##           master    #3967      +/-   ##
==========================================
- Coverage   83.72%   83.71%   -0.02%     
==========================================
  Files         223      223              
  Lines       32984    33008      +24     
==========================================
+ Hits        27615    27631      +16     
- Misses       5369     5377       +8     
Flag Coverage Δ
ui-tests 37.29% <90.32%> (+0.35%) ⬆️
unitexamples-tests 74.89% <20.96%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/convert.py 67.96% <87.50%> (-0.90%) ⬇️
panel/tests/ui/io/test_convert.py 95.28% <91.83%> (-3.57%) ⬇️
panel/io/resources.py 86.80% <100.00%> (+0.09%) ⬆️
panel/models/tabulator.py 97.77% <100.00%> (ø)
panel/widgets/tables.py 88.31% <100.00%> (ø)
panel/io/state.py 69.89% <0.00%> (-0.37%) ⬇️
panel/tests/util.py 89.32% <0.00%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 08e436b into master Oct 8, 2022
@philippjfr philippjfr deleted the tabulator_resource_fix branch October 8, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant