Improve support for requests in pyodide #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3973 +/- ##
==========================================
- Coverage 83.71% 83.46% -0.25%
==========================================
Files 223 223
Lines 33008 33039 +31
==========================================
- Hits 27631 27576 -55
- Misses 5377 5463 +86
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
thank you for using pyodide-http! Pyodide-http patches urllib. Under the hood urllib is used by pandas to read remote data. All read_* function should work out of the box after applying the patch. |
|
Nice, thanks! Was going to do some experimenting, particularly in regard to fsspec. I guess that also uses urllib under the hood in which case this is even more exciting than I'd dared to hope. |
|
Wow. I've been dreaming about this. Thought it was not possible. |
philippjfr
force-pushed
the
binary_pyodide
branch
from
3f3cbb2
to
25c6a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyodide-httpas a dependency for converted pyodide apps ensuring thatrequestsandurllib3work (even for binary files if using thepyodide-workertarget)Imagepane.