Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle future exceptions on threads #3977

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

philippjfr
Copy link
Member

Fixes #3974

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3977 (23b0f80) into master (08e436b) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #3977      +/-   ##
==========================================
- Coverage   83.71%   83.70%   -0.01%     
==========================================
  Files         223      223              
  Lines       33008    33010       +2     
==========================================
- Hits        27631    27630       -1     
- Misses       5377     5380       +3     
Flag Coverage Δ
ui-tests 37.28% <20.00%> (-0.01%) ⬇️
unitexamples-tests 74.88% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/reactive.py 78.09% <50.00%> (ø)
panel/io/state.py 69.58% <66.66%> (-0.31%) ⬇️
panel/io/callbacks.py 79.25% <100.00%> (+0.15%) ⬆️
panel/tests/util.py 88.34% <0.00%> (-0.98%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 14019ef into master Oct 10, 2022
@philippjfr philippjfr deleted the threaded_exception branch October 10, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception handler does not work when threading is enabled
1 participant