Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of Tabulator edited index #3988

Merged
merged 3 commits into from Oct 14, 2022
Merged

Conversation

philippjfr
Copy link
Member

Attempt at fixing part of #3984

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3988 (67999c4) into master (439a711) will decrease coverage by 0.01%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##           master    #3988      +/-   ##
==========================================
- Coverage   83.70%   83.68%   -0.02%     
==========================================
  Files         223      223              
  Lines       33117    33122       +5     
==========================================
- Hits        27719    27717       -2     
- Misses       5398     5405       +7     
Flag Coverage Δ
ui-tests 37.58% <16.66%> (-0.01%) ⬇️
unitexamples-tests 74.70% <61.11%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/tables.py 87.85% <56.25%> (-0.59%) ⬇️
panel/models/tabulator.py 97.80% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 747dc49 into master Oct 14, 2022
@philippjfr philippjfr deleted the tabulator_pre_edit branch October 14, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant