Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure periodic callbacks are only started on main thread #4011

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

philippjfr
Copy link
Member

Fixes #4010

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #4011 (5ca16b7) into master (00a4f30) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #4011      +/-   ##
==========================================
- Coverage   83.67%   83.65%   -0.03%     
==========================================
  Files         223      223              
  Lines       33130    33129       -1     
==========================================
- Hits        27723    27714       -9     
- Misses       5407     5415       +8     
Flag Coverage Δ
ui-tests 37.58% <66.66%> (+<0.01%) ⬆️
unitexamples-tests 74.68% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/callbacks.py 78.83% <66.66%> (-0.43%) ⬇️
panel/io/state.py 69.87% <100.00%> (+0.73%) ⬆️
panel/io/django.py 11.32% <0.00%> (-18.87%) ⬇️
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 742fbc5 into master Oct 16, 2022
@philippjfr philippjfr deleted the threading_start_periodic branch October 16, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: There is no current event loop in thread 'ThreadPoolExecutor-0_0'.
1 participant