Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure jupyter server extension handles explicit root_dir #4029

Merged
merged 1 commit into from Oct 19, 2022

Conversation

philippjfr
Copy link
Member

Fixes #4017

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #4029 (12bc44a) into master (9c819d0) will increase coverage by 8.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4029      +/-   ##
==========================================
+ Coverage   74.65%   83.63%   +8.97%     
==========================================
  Files         223      223              
  Lines       33148    33146       -2     
==========================================
+ Hits        24748    27720    +2972     
+ Misses       8400     5426    -2974     
Flag Coverage Δ
ui-tests 37.59% <0.00%> (?)
unitexamples-tests 74.63% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.95% <0.00%> (-1.42%) ⬇️
panel/io/cache.py 82.14% <0.00%> (-0.45%) ⬇️
panel/io/state.py 69.52% <0.00%> (-0.35%) ⬇️
panel/io/server.py 74.47% <0.00%> (-0.20%) ⬇️
panel/param.py 87.22% <0.00%> (+0.15%) ⬆️
panel/pane/idom.py 28.36% <0.00%> (+0.19%) ⬆️
panel/pane/base.py 87.91% <0.00%> (+0.41%) ⬆️
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 2eaa211 into master Oct 19, 2022
@philippjfr philippjfr deleted the jupyter_root_dir_handling branch October 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError in Panel preview pane in JupyterHub (lab)
1 participant