Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure embedded slider initializes with correct default #4121

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

philippjfr
Copy link
Member

Fixes #4106

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #4121 (2540bc3) into master (0354e10) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4121   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         223      223           
  Lines       33280    33294   +14     
=======================================
+ Hits        27815    27827   +12     
- Misses       5465     5467    +2     
Flag Coverage Δ
ui-tests 37.59% <6.66%> (-0.02%) ⬇️
unitexamples-tests 74.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/io/test_embed.py 99.44% <100.00%> (+0.02%) ⬆️
panel/widgets/slider.py 95.14% <100.00%> (+<0.01%) ⬆️
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 66b1e68 into master Nov 15, 2022
@philippjfr philippjfr deleted the slider_init branch November 15, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.embed() does not honor default widget values
1 participant