Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tab headers do not scroll unnecessarily #4146

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

philippjfr
Copy link
Member

The width of the tab headers was incorrectly calculated leading to a scroll bar appearing when it wasn't needed.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #4146 (d849352) into master (c1e14aa) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
- Coverage   37.62%   37.56%   -0.07%     
==========================================
  Files         224      224              
  Lines       33382    33382              
==========================================
- Hits        12561    12539      -22     
- Misses      20821    20843      +22     
Flag Coverage Δ
ui-tests 37.56% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/ui/io/test_jupyterlite.py 83.78% <0.00%> (-8.11%) ⬇️
panel/tests/ui/io/test_convert.py 90.26% <0.00%> (-2.66%) ⬇️
panel/tests/conftest.py 50.86% <0.00%> (-1.30%) ⬇️
panel/tests/util.py 55.88% <0.00%> (-0.99%) ⬇️
panel/io/cache.py 23.21% <0.00%> (ø)
panel/io/state.py 34.30% <0.00%> (+0.18%) ⬆️
panel/io/server.py 29.71% <0.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 1d4e5e2 into master Nov 22, 2022
@philippjfr philippjfr deleted the tabs_header_fix branch November 22, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant