Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not dispatch events if hold value is set #4178

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

philippjfr
Copy link
Member

Not sure what the thinking here was but we should not be dispatching events if the Document has been set to hold. Holding is a powerful way to batch events and we should not stop users from taking advantage of it.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #4178 (928ad6e) into master (55fd4b8) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   83.61%   83.54%   -0.07%     
==========================================
  Files         224      225       +1     
  Lines       33527    33542      +15     
==========================================
- Hits        28032    28022      -10     
- Misses       5495     5520      +25     
Flag Coverage Δ
ui-tests 37.55% <29.16%> (-0.07%) ⬇️
unitexamples-tests 74.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/document.py 56.17% <100.00%> (+0.68%) ⬆️
panel/tests/io/test_document.py 100.00% <100.00%> (ø)
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/ui/io/test_jupyterlite.py 89.18% <0.00%> (-8.11%) ⬇️
panel/tests/util.py 87.37% <0.00%> (-3.89%) ⬇️
panel/tests/ui/io/test_convert.py 92.92% <0.00%> (-2.66%) ⬇️
panel/tests/conftest.py 87.12% <0.00%> (-1.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3ccd431 into master Dec 6, 2022
@philippjfr philippjfr deleted the avoid_hold_dispatch branch December 6, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant