Deprecate ReactTemplate, IDOM pane and Viewable.app #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds sensible. You could collect the bereaking changes you want to do. Announce them on discourse, Twitter and LinkedIn. Then its hard for users to get upset if they did not react. And if you overlooked something you could get the feedback. |
hoxbro
reviewed
Jan 16, 2023
|
I have no objection to the removal of these. Does this mean that VTK is being kept in Panel 1.0? |
I had planned to write a |
|
Sounds reasonable to me. |
philippjfr
changed the title
philippjfr
added a commit
that referenced
this pull request
Jan 26, 2023
* Deprecate VanillaTemplate, ReactTemplate, IDOM pane and Viewable.app * Back out of VanillaTemplate deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion I've decided to execute a few deprecations ahead of the 1.0 release.
For templates I've simply decided that we do not need 5 different ListTemplate implementations and multiple grid template implementations. Deprecating some of these implementations will allow us to better focus on styling existing templates and reduces the maintenance burden.
Here are the deprecations I'm suggesting:
IDOMpane: We only support version 0.24 currently which is very old. Since we do not have a maintainer who could update it and Reacton fills the same niche I've decided to remove it. It may be it could be re-added later in apanel-idompackage but without anyone requesting support I think the right decision is to remove it.ReactTemplate: TheReactTemplateis overall pretty nice BUT the naming is terrible (it's built on top of a React library but it doesn't actually allow you to use React or anything so really that's an implementation detail. Secondly, theFastGridTemplatelets you do the exact same thing but looks prettier.Viewable.app: The.appmethod allows starting a server in Jupyter and then embedding it as an iframe. This relies on the port being accessible and to specify thenotebook_url. This is brittle without much benefit at all because you already get interactivity in a notebook without running a server. I've left the function that will let you do the same thing but we don't need a method on all objects to do this.Please chime in with thoughts and/or objections.
Ping @MarcSkovMadsen, @jbednar, @maximlt, @hoxbro