Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hash_funcs are applied recursively in cache #4334

Merged
merged 1 commit into from Jan 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4139

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #4334 (0e01280) into main (47f231b) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4334      +/-   ##
==========================================
- Coverage   82.75%   82.61%   -0.15%     
==========================================
  Files         240      240              
  Lines       34558    34566       +8     
==========================================
- Hits        28598    28555      -43     
- Misses       5960     6011      +51     
Flag Coverage Δ
ui-tests 37.99% <30.00%> (-0.31%) ⬇️
unitexamples-tests 73.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/cache.py 83.69% <100.00%> (+1.02%) ⬆️
panel/tests/ui/widgets/test_misc.py 33.33% <0.00%> (-64.11%) ⬇️
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/ui/io/test_jupyterlite.py 89.74% <0.00%> (-7.70%) ⬇️
panel/tests/util.py 87.37% <0.00%> (-3.89%) ⬇️
panel/tests/ui/io/test_convert.py 93.10% <0.00%> (-2.59%) ⬇️
panel/tests/conftest.py 88.08% <0.00%> (-1.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 325cb81 into main Jan 26, 2023
@philippjfr philippjfr deleted the fix_hash_func_override_fix branch January 26, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.cache(hash_funcs=custom_funcs, ...) are not applied recursively (ie. at all)
1 participant