Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest react-grid from CDN #4461

Merged
merged 3 commits into from Feb 21, 2023
Merged

Use latest react-grid from CDN #4461

merged 3 commits into from Feb 21, 2023

Conversation

philippjfr
Copy link
Member

Fixes #3565

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #4461 (9ac7c10) into main (72049e0) will decrease coverage by 8.17%.
The diff coverage is n/a.

❗ Current head 9ac7c10 differs from pull request most recent head a0427d3. Consider uploading reports for the commit a0427d3 to get more accurate results

@@            Coverage Diff             @@
##             main    #4461      +/-   ##
==========================================
- Coverage   81.78%   73.61%   -8.17%     
==========================================
  Files         243      243              
  Lines       35234    35234              
==========================================
- Hits        28815    25938    -2877     
- Misses       6419     9296    +2877     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/template/react/__init__.py 100.00% <ø> (ø)
panel/tests/ui/widgets/test_tabulator.py 9.51% <0.00%> (-88.71%) ⬇️
panel/tests/ui/widgets/test_input.py 11.34% <0.00%> (-88.13%) ⬇️
panel/tests/ui/layout/test_accordion.py 14.72% <0.00%> (-85.28%) ⬇️
panel/tests/ui/widgets/test_sliders.py 15.42% <0.00%> (-84.58%) ⬇️
panel/tests/ui/layout/test_card.py 18.48% <0.00%> (-81.52%) ⬇️
panel/tests/ui/pane/test_image.py 25.80% <0.00%> (-74.20%) ⬇️
panel/tests/ui/test_reactive.py 26.53% <0.00%> (-73.47%) ⬇️
panel/tests/ui/pane/test_markup.py 28.00% <0.00%> (-72.00%) ⬇️
panel/tests/ui/template/test_fastgridtemplate.py 28.57% <0.00%> (-71.43%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 839bbf4 into main Feb 21, 2023
@philippjfr philippjfr deleted the react_grid_url branch February 21, 2023 14:49
maximlt pushed a commit that referenced this pull request Mar 2, 2023
* Use latest react-grid from CDN

* Fix url

* Fix React template
maximlt added a commit that referenced this pull request Mar 3, 2023
* keywords and like filters aren't regex (#4423)
* add examples folder dynamically added to the distrib (#4484)
* Small bug fixes  (#4481)
* use the right name for the method that gets the image data
* Bump cryptography in /examples/apps/django_multi_apps (#4418)
* Use latest react-grid from CDN (#4461)
* Fix url
* Fix React template
* prepare release notes
* Modify sys.path when running inside Jupyter Kernel (#4489)
* Add support for altair and vega-lite v5 (#4488)
* Do not re-create Vega.selections object unless selections changed (#4497)
* Bump panel.js version to 0.14.4-rc.2

---------

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactTemplate and used external resources
1 participant