Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mimetype issue #4738

Merged
merged 3 commits into from Apr 29, 2023
Merged

Fix mimetype issue #4738

merged 3 commits into from Apr 29, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #4721

@MarcSkovMadsen MarcSkovMadsen added this to the v1.0.0 milestone Apr 29, 2023
panel/io/resources.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #4738 (4e7a0ad) into main (f5da674) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4e7a0ad differs from pull request most recent head 8d483f4. Consider uploading reports for the commit 8d483f4 to get more accurate results

@@           Coverage Diff           @@
##             main    #4738   +/-   ##
=======================================
  Coverage   73.21%   73.22%           
=======================================
  Files         268      268           
  Lines       37681    37681           
=======================================
+ Hits        27590    27591    +1     
+ Misses      10091    10090    -1     
Flag Coverage Δ
unitexamples-tests 73.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/resources.py 84.03% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

panel/io/resources.py Outdated Show resolved Hide resolved
@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Apr 29, 2023

It might be simpler and faster to not .init and check. But just run mimetypes.add_type("application/javascript", ".js") always. Even though the name is add_type if is really an add_or_update_type function.

@philippjfr
Copy link
Member

It might be simpler and faster to not .init and check. But just run mimetypes.add_type("application/javascript", ".js") always. Even though the name is add_type if is really an add_or_update_type function.

+1 this makes sense to me.

@MarcSkovMadsen
Copy link
Collaborator Author

Thanks @philippjfr . I've just pushed the simplification and the PR should be ready.

@philippjfr philippjfr merged commit b152b7c into main Apr 29, 2023
11 of 14 checks passed
@philippjfr philippjfr deleted the fix/mime-type-issue-on-windows branch April 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load module script
2 participants