Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Reactive objects are re-rendered correctly #4868

Merged
merged 1 commit into from May 17, 2023
Merged

Conversation

philippjfr
Copy link
Member

Ensure that we only implement custom object handling for PaneBase types.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #4868 (0d10cc8) into main (753cc20) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4868      +/-   ##
==========================================
+ Coverage   83.21%   83.35%   +0.13%     
==========================================
  Files         270      270              
  Lines       38120    38122       +2     
==========================================
+ Hits        31721    31776      +55     
+ Misses       6399     6346      -53     
Flag Coverage Δ
ui-tests 40.82% <0.00%> (+1.02%) ⬆️
unitexamples-tests 73.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/base.py 83.65% <100.00%> (-0.19%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr added this to the 1.0.1 milestone May 17, 2023
@philippjfr philippjfr merged commit b2e5d13 into main May 17, 2023
14 of 15 checks passed
@philippjfr philippjfr deleted the rerender_fix branch May 17, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant