Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for loading indicator #4915

Merged
merged 3 commits into from May 22, 2023
Merged

Various fixes for loading indicator #4915

merged 3 commits into from May 22, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4911

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #4915 (920422e) into main (f8770f3) will decrease coverage by 41.76%.
The diff coverage is 100.00%.

❗ Current head 920422e differs from pull request most recent head a1d7832. Consider uploading reports for the commit a1d7832 to get more accurate results

@@             Coverage Diff             @@
##             main    #4915       +/-   ##
===========================================
- Coverage   82.65%   40.89%   -41.76%     
===========================================
  Files         270      270               
  Lines       38141    38144        +3     
===========================================
- Hits        31526    15600    -15926     
- Misses       6615    22544    +15929     
Flag Coverage Δ
ui-tests 40.89% <100.00%> (+<0.01%) ⬆️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/server.py 43.22% <ø> (-29.04%) ⬇️
panel/io/convert.py 72.18% <100.00%> (+0.10%) ⬆️
panel/io/loading.py 100.00% <100.00%> (ø)
panel/io/resources.py 66.30% <100.00%> (-20.79%) ⬇️
panel/links.py 22.30% <100.00%> (-60.59%) ⬇️
panel/tests/ui/io/test_convert.py 93.38% <100.00%> (-2.48%) ⬇️

... and 173 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 6ddc43d into main May 22, 2023
13 of 14 checks passed
@philippjfr philippjfr deleted the loading_fix branch May 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner isn't visible
1 participant