Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -1 in Tabs.active #4920

Merged
merged 1 commit into from May 23, 2023
Merged

Allow -1 in Tabs.active #4920

merged 1 commit into from May 23, 2023

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented May 23, 2023

Fixes #4919

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #4920 (11cfd6f) into main (0c9cce3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4920      +/-   ##
==========================================
+ Coverage   83.43%   83.44%   +0.01%     
==========================================
  Files         270      270              
  Lines       38156    38156              
==========================================
+ Hits        31834    31838       +4     
+ Misses       6322     6318       -4     
Flag Coverage Δ
ui-tests 40.89% <50.00%> (+<0.01%) ⬆️
unitexamples-tests 73.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/layout/tabs.py 90.75% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good if it works!

@Hoxbro
Copy link
Member Author

Hoxbro commented May 23, 2023

It does!

screenrecord-2023-05-23_15.52.26.mp4

@philippjfr philippjfr merged commit 68f50dd into main May 23, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the fix_tabs_no_active branch May 23, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error raised when removing last tab for pn.Tabs component
2 participants