Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure VSCode does not apply white background #4923

Merged
merged 2 commits into from May 24, 2023
Merged

Ensure VSCode does not apply white background #4923

merged 2 commits into from May 24, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4910

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #4923 (89108c3) into main (013434f) will decrease coverage by 12.72%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #4923       +/-   ##
===========================================
- Coverage   83.45%   70.73%   -12.72%     
===========================================
  Files         270      270               
  Lines       38171    38171               
===========================================
- Hits        31854    27002     -4852     
- Misses       6317    11169     +4852     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 70.73% <ø> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 78 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 95bdcb2 into main May 24, 2023
9 of 15 checks passed
@philippjfr philippjfr deleted the vscode_fixes branch May 24, 2023 10:13
}

/* Override VSCode background color */
.cell-output-ipywidget-background:has(> .cell-output-ipywidget-background
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:has() pseudo selector is not available in Firefox yet. Given this change is related to vscode, then maybe this is not a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widgets does not show up correctly in VS Code
2 participants