Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective make over #5087

Merged
merged 4 commits into from Jun 13, 2023
Merged

Perspective make over #5087

merged 4 commits into from Jun 13, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jun 10, 2023

Todo:

  • Improve documentation
  • Review and improve
  • Upload assets to CDN and replace links in notebook

Nice to have

  • Upgrade to latest version of Perspective if possible

Closes

Improves on

Correlated issues

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #5087 (8ad4dc8) into main (60ba9c9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8ad4dc8 differs from pull request most recent head 9c448cd. Consider uploading reports for the commit 9c448cd to get more accurate results

@@            Coverage Diff             @@
##             main    #5087      +/-   ##
==========================================
+ Coverage   83.66%   83.67%   +0.01%     
==========================================
  Files         274      274              
  Lines       39133    39133              
==========================================
+ Hits        32739    32745       +6     
+ Misses       6394     6388       -6     
Flag Coverage Δ
ui-tests 40.54% <ø> (+0.01%) ⬆️
unitexamples-tests 73.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarcSkovMadsen
Copy link
Collaborator Author

Assets

image

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review June 10, 2023 05:54
@MarcSkovMadsen
Copy link
Collaborator Author

This one is ready for review @philippjfr . So happy about this one. Feels almost like having a new, game changing widget to Panel because its now much, much easier to use.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a really great improvement!

@philippjfr philippjfr merged commit f7e6060 into main Jun 13, 2023
10 of 14 checks passed
@philippjfr philippjfr deleted the enhancement/perspective-make-over branch June 13, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Perspective Styling Add Perspective date and number formatting
2 participants