Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChatBox issues #5101

Merged
merged 5 commits into from Jun 13, 2023
Merged

Fix ChatBox issues #5101

merged 5 commits into from Jun 13, 2023

Conversation

ahuang11
Copy link
Contributor

While trying to use it for an actual use case, I found some problems with it, namely:

  1. Send button height stretches too far ChatBox Send button stretches too far. #5100
  2. ChatBox inputs cannot be disabled ChatBox cannot be disabled #5099
  3. pn.bind didn't work with append because previously, append doesn't actually trigger value in the latest patch
  4. If append now trigger values, it does a whole refresh and liked again gets lost so I added logic to match up the messages along with index

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #5101 (9c9f812) into main (285db25) will increase coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5101      +/-   ##
==========================================
+ Coverage   82.93%   83.73%   +0.79%     
==========================================
  Files         274      274              
  Lines       39133    39254     +121     
==========================================
+ Hits        32455    32869     +414     
+ Misses       6678     6385     -293     
Flag Coverage Δ
ui-tests 40.44% <16.94%> (-0.06%) ⬇️
unitexamples-tests 73.81% <100.00%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_chatbox.py 100.00% <100.00%> (ø)
panel/widgets/chatbox.py 95.33% <100.00%> (+0.10%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahuang11 ahuang11 requested a review from philippjfr June 13, 2023 15:37
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@philippjfr philippjfr merged commit d04fbce into main Jun 13, 2023
14 of 15 checks passed
@philippjfr philippjfr deleted the enhance_chatbox branch June 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants