Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChatBox methods and replacing ChatRow values #5118

Merged
merged 2 commits into from Jun 15, 2023
Merged

Conversation

ahuang11
Copy link
Contributor

As I was building my AI chat box I felt like pn.widgets.ChatBox was missing some core functionality so this PR adds:

  • Allows updating row message
  • Adds insert, pop, replace list methods

@ahuang11 ahuang11 changed the title Add chatbox methods Add ChatBox methods and replacing ChatRow values Jun 15, 2023
@ahuang11
Copy link
Contributor Author

Actually dropping support for Allows updating row message because it gets out of sync with ChatBox.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #5118 (e931bb4) into main (111242a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
+ Coverage   83.71%   83.75%   +0.03%     
==========================================
  Files         274      274              
  Lines       39274    39391     +117     
==========================================
+ Hits        32880    32993     +113     
- Misses       6394     6398       +4     
Flag Coverage Δ
ui-tests 40.45% <11.76%> (+0.02%) ⬆️
unitexamples-tests 73.80% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_chatbox.py 100.00% <100.00%> (ø)
panel/widgets/chatbox.py 95.54% <100.00%> (+0.20%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahuang11
Copy link
Contributor Author

ahuang11 commented Jun 15, 2023

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@philippjfr philippjfr merged commit b0ba5e3 into main Jun 15, 2023
13 of 15 checks passed
@philippjfr philippjfr deleted the add_chatbox_methods branch June 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants