Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow names to be disabled for chatbox #5152

Merged
merged 3 commits into from Jun 21, 2023
Merged

Allow names to be disabled for chatbox #5152

merged 3 commits into from Jun 21, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jun 21, 2023

chat_box = pn.widgets.ChatBox(
    value=[
        {"You": "Hello!"},
        {"Machine": "Hi there!"},
        {"GPT3.5": "Hey all!"},
        {"GPT4": "Greetings!"},
    ],
    message_icons={
        "You": "https://user-images.githubusercontent.com/42288570/246667322-33a2a320-9ea3-4e79-8fb8-fcb5b6eac9c0.png",
        "Machine": "https://user-images.githubusercontent.com/42288570/246671017-d3a26763-f7f5-4e8d-8933-cb69670f90a8.svg",
        "GPT3.5": "https://user-images.githubusercontent.com/42288570/246667325-ad4e3434-d173-4463-bb98-5c5d4a892b25.png",
        "GPT4": "https://user-images.githubusercontent.com/42288570/246667324-5cf26789-765f-4f76-a8bf-49309d2ae84f.png",
    },
    allow_names=False,
)

chat_box

Continues addressing #5135

image

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #5152 (2b0eafd) into main (b53c4a5) will decrease coverage by 10.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5152       +/-   ##
===========================================
- Coverage   83.78%   73.70%   -10.08%     
===========================================
  Files         274      274               
  Lines       39491    39498        +7     
===========================================
- Hits        33086    29112     -3974     
- Misses       6405    10386     +3981     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_chatbox.py 100.00% <100.00%> (ø)
panel/widgets/chatbox.py 95.61% <100.00%> (+0.01%) ⬆️

... and 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Plotly test failures seem unrelated, I'll merge and then fix up the tests.

@philippjfr philippjfr merged commit 5bf801d into main Jun 21, 2023
10 of 15 checks passed
@philippjfr philippjfr deleted the allow_names branch June 21, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants